[Merge] ~giner/livecd-rootfs:vagrant_use_dummy_file_for_console_output into livecd-rootfs:ubuntu/master

[John Chittum]

Review: Needs Fixing

Thank you for the contribution. This looks like a good change to help speed up Vagrant boots. One inline comment.

Diff comments:

> diff --git a/live-build/ubuntu-cpc/hooks.d/base/vagrant.binary b/live-build/ubuntu-cpc/hooks.d/base/vagrant.binary
> index f9b21d3..ff7d459 100755
> --- a/live-build/ubuntu-cpc/hooks.d/base/vagrant.binary
> +++ b/live-build/ubuntu-cpc/hooks.d/base/vagrant.binary
> @@ -154,8 +154,10 @@ Vagrant.configure("2") do |config|
>  
>    config.vm.provider "virtualbox" do |vb|
>       vb.customize [ "modifyvm", :id, "--uart1", "0x3F8", "4" ]
> -# Creating a console log file is not an expected behavior for vagrant boxes. LP #1777827
> -#     vb.customize [ "modifyvm", :id, "--uartmode1", "file", File.join(Dir.pwd, "${prefix}-console.log") ]
> +     # Creating a console log file is not an expected behavior for vagrant boxes. LP #1777827
> +     #vb.customize [ "modifyvm", :id, "--uartmode1", "file", File.join(Dir.pwd, "${prefix}-console.log") ]
> +     # Use dummy file for the console output. LP #1874453

Could you make the comment more explicit as well as the link to the LP? Also, could you either remove the console log code or state that this is an example of creating a local file rather than sending to NULL?

> +     vb.customize [ "modifyvm", :id, "--uartmode1", "file", File::NULL ]
>    end
>  end
>  EOF


-- 
https://code.launchpad.net/~giner/livecd-rootfs/+git/livecd-rootfs/+merge/388963
Your team Ubuntu Core Development Team is requested to review the proposed merge of ~giner/livecd-rootfs:vagrant_use_dummy_file_for_console_output into livecd-rootfs:ubuntu/master.