[Merge] ~ddstreet/livecd-rootfs:remove-software-properties-dep into livecd-rootfs:ubuntu/master
Colin Watson
cjwatson at canonical.com
Thu Aug 13 13:33:57 UTC 2020
Diff comments:
> diff --git a/get-ppa-fingerprint b/get-ppa-fingerprint
> index f691041..5d5d1a3 100755
> --- a/get-ppa-fingerprint
> +++ b/get-ppa-fingerprint
> @@ -12,6 +11,5 @@ _, args = parser.parse_args()
> if not args:
> parser.error("must provide a PPA owner/name")
> owner_name, ppa_name = args[0].split("/", 1)
> -owner_name = "~%s" % owner_name
> -ppa_info = ppa.get_ppa_info_from_lp(owner_name, ppa_name)
> -print(ppa_info["signing_key_fingerprint"])
> +fp = urlopen(f"https://api.launchpad.net/devel/~{owner_name}/+archive/ubuntu/{ppa_name}/signing_key_fingerprint").read()
> +print(fp.decode().strip('"').strip("'"))
Could you pass this through `json.loads()` rather than doing ad-hoc decoding?
--
https://code.launchpad.net/~ddstreet/livecd-rootfs/+git/livecd-rootfs/+merge/389235
Your team Ubuntu Core Development Team is subscribed to branch livecd-rootfs:ubuntu/master.
More information about the Ubuntu-reviews
mailing list