[Merge] ~mitya57/compiz:s390x-test into compiz:master

Sam Spilsbury smspillaz at gmail.com
Wed Aug 12 21:54:21 UTC 2020


It may be that the xlib manual should be updated. The documentation on the "format" parameter is a tad misleading, especially if you don't read the next section:

> format: 	Specifies whether the data should be viewed as a list of 8-bit, 16-bit, or 32-bit quantities. Possible values are 8, 16, and 32. This information allows the X server to correctly perform byte-swap operations as necessary. *If the format is 16-bit or 32-bit, you must explicitly cast your data pointer to an (unsigned char *) in the call to XChangeProperty().*

>  If the specified format is 8, the property data must be a char array. If the specified format is 16, the property data must be a short array. If the specified format is 32, the property data must be a long array. 

The first section implies that "16" means 16 bits and "32" means 32 bits, the next section says "16" means short (16 bits everywhere), "32" means long, which in turn means 32 bits on 32 bit platforms and 64 bits on 64 bit platforms.
-- 
https://code.launchpad.net/~mitya57/compiz/+git/compiz/+merge/389101
Your team Compiz Maintainers is subscribed to branch compiz:master.



More information about the Ubuntu-reviews mailing list