[Merge] ~rcj/livecd-rootfs/+git/livecd-rootfs:bugfix/snapd_for_core18-eoan into livecd-rootfs:ubuntu/eoan

[Robert C Jennings]

Robert C Jennings has proposed merging ~rcj/livecd-rootfs/+git/livecd-rootfs:bugfix/snapd_for_core18-eoan into livecd-rootfs:ubuntu/eoan.

Commit message:
Ensure snapd is seeded in core18-only images (and no implicit core snap)

The _snap_post_process function is meant to install snapd if core18 is the
only core snap installed or removed snapd if core is installed and snapd
was not explicitly installed. But the current logic in _snap_preseed
will never call _snap_post_process. $core_name will never be empty
with the existing logic, but even if it were that would only be for the
'core' snap and we'd miss using the 'core18' logic that pulls in snapd.
Given the case statement in _snap_post_process can handle doing the
right thing given any snap we can just call it unconditionally.

Seeing any snap via snap_preseed will evaluate the base for each snap
and seed the appropriate base. There should be no reason to explicitly
seed the 'core' snap and with snaps moving to 'core1

Requested reviews:
  Ubuntu Core Development Team (ubuntu-core-dev)
Related bugs:
  Bug #1871919 in livecd-rootfs (Ubuntu): "images with only core18-based snaps fail to build"
  https://bugs.launchpad.net/ubuntu/+source/livecd-rootfs/+bug/1871919

For more details, see:
https://code.launchpad.net/~rcj/livecd-rootfs/+git/livecd-rootfs/+merge/382312
-- 
Your team Ubuntu Core Development Team is requested to review the proposed merge of ~rcj/livecd-rootfs/+git/livecd-rootfs:bugfix/snapd_for_core18-eoan into livecd-rootfs:ubuntu/eoan.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 1455 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20200415/105ebb70/attachment.diff>