[Merge] ~rafaeldtinoco/ubuntu/+source/sg3-utils:lp1833618-eoan into ubuntu/+source/sg3-utils:ubuntu/eoan-devel

Rafael David Tinoco rafaeldtinoco at kernelpath.com
Tue Oct 8 22:21:19 UTC 2019


I'm rejecting this MR due to:

"""
Both, upstream version and Debian version already have the following change:

commit 988e967513fc9dc2be35dcb5bbc6b888f853538f
Author: Douglas Gilbert <dgilbert at interlog.com>
Date: Wed May 11 17:20:52 2016

    rescan-scsi-bus.sh + 55-scsi-sg3_id.rules: fixes from HR at Suse

    git-svn-id: svn://localhost/trunk@703 6180dd3e-e324-4e3e-922d-17de1ae2f315

which fix the SERIAL issue (but not the delay in insertion caused by errors of sg_inq commands).

That will be enough for this particular case (MAAS related). I can, during the next merge (F-series) propose to upstream a change not to execute sg_inq 0x83 if 0x80 wasn't successful, but, for now, taking in consideration the phase we are for Eoan (almost freeze), I'll base the changes in the upstream commit (at least the changes for 55-scsi-sg3_id.rules changes).

...

"""

from https://bugs.launchpad.net/curtin/+bug/1833618/comments/62.
-- 
https://code.launchpad.net/~rafaeldtinoco/ubuntu/+source/sg3-utils/+git/sg3-utils/+merge/373438
Your team Ubuntu Core Development Team is requested to review the proposed merge of ~rafaeldtinoco/ubuntu/+source/sg3-utils:lp1833618-eoan into ubuntu/+source/sg3-utils:ubuntu/eoan-devel.



More information about the Ubuntu-reviews mailing list