[Merge] lp:~khurshid-alam/notify-osd/fix-gnotification-icon into lp:notify-osd

Khurshid Alam khurshid.alam at linuxmail.org
Fri Nov 29 11:33:27 UTC 2019


Khurshid Alam has proposed merging lp:~khurshid-alam/notify-osd/fix-gnotification-icon into lp:notify-osd.

Commit message:
Support 'image-path' as hint

Both freedesktop notification (https://developer.gnome.org/notification-spec/) spec & Gnotification use image-path as hint where notify-osd only uses image_path.

As a result when one uses themed icon with Gnotification it doesn't show the icon. Support for themed icon landed in https://github.com/GNOME/glib/commit/ec1edef3

Fixes LP: #1840741

Requested reviews:
  Sebastien Bacher (seb128)
Related bugs:
  Bug #1840741 in notify-osd (Ubuntu): "Notify-osd doesn't show icon with Gnotification"
  https://bugs.launchpad.net/ubuntu/+source/notify-osd/+bug/1840741

For more details, see:
https://code.launchpad.net/~khurshid-alam/notify-osd/fix-gnotification-icon/+merge/376177
-- 
Your team Indicator Applet Developers is subscribed to branch lp:notify-osd.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 576 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20191129/f4d5bd51/attachment.diff>


More information about the Ubuntu-reviews mailing list