[Merge] ~ubuntu-server-ha/ubuntu/+source/resource-agents:resource-agents-4.4.0-1ubuntu1 into ubuntu/+source/resource-agents:debian/sid

[Andreas Hasenack]

Review: Needs Fixing

- split equals old/ubuntu, check
- split commits are good
- logical to old/ubuntu: just metadata, check
- dropped delta. Ok, but I would prefer if the changelog mentioned that the reason these patches were dropped is because it was fixed upstream, not in debian. When you say it's fixed in debian, it implies that the patches were adopted by debian, which is not the case. You don't have to research in which upstream release the issue was fixed, just saying "Fixed upstream" is enough.

While looking at debian's 4.4.0 changes, this jumped out:
  * debian/control: add Pre-Depends to ldirectord

At first I thought this was adding ldirectord to a pre-depends, and that could be a no-no because this package is in universe, but in fact it's adding this line to the ldirectord package section:
+Pre-Depends: ${misc:Pre-Depends}

That is dynamically generated. Checking what ended up in the package in the end shows:
 Pre-Depends: init-system-helpers (>= 1.54~)

In terms of pockets, that is in main, and seems fine. Looks like it came as a result of this lintian warning: https://lintian.debian.org/tags/skip-systemd-native-flag-missing-pre-depends.html

Just please adjust the d/changelog messaging about why the patches were dropped

-- 
https://code.launchpad.net/~ubuntu-server-ha/ubuntu/+source/resource-agents/+git/resource-agents/+merge/375322
Your team Ubuntu Server Developers is requested to review the proposed merge of ~ubuntu-server-ha/ubuntu/+source/resource-agents:resource-agents-4.4.0-1ubuntu1 into ubuntu/+source/resource-agents:debian/sid.