[Merge] ~laney/software-properties:token-pass-empty-string-not-none into software-properties:ubuntu/master

Iain Lane iain at orangesquash.org.uk
Fri May 24 11:21:24 UTC 2019


Iain Lane has proposed merging ~laney/software-properties:token-pass-empty-string-not-none into software-properties:ubuntu/master.

Requested reviews:
  Sebastien Bacher (seb128)
  Ubuntu Core Development Team (ubuntu-core-dev)
Related bugs:
  Bug #1830348 in software-properties (Ubuntu): "/usr/bin/software-properties-gtk:TypeError:msg_reply_handler:_enabled_reply_handler:__call__:call_async"
  https://bugs.launchpad.net/ubuntu/+source/software-properties/+bug/1830348

For more details, see:
https://code.launchpad.net/~laney/software-properties/+git/software-properties/+merge/367899

livepatch: Always pass a string to SetLivePatchEnabled
    
In the error case where we fail to retrieve a token, we'll get None back
from GOA. The D-Bus interface expects a string, so pass it an empty
string to avoid tracebacks  and correctly display an error to the user.
    
This was already done in one case, but the retry case wasn't handled in
this way.

LP: #1830348
-- 
Your team Ubuntu Core Development Team is requested to review the proposed merge of ~laney/software-properties:token-pass-empty-string-not-none into software-properties:ubuntu/master.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 811 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20190524/e65c8f11/attachment.diff>


More information about the Ubuntu-reviews mailing list