[Merge] ~rbalint/livecd-rootfs:wsl into livecd-rootfs:ubuntu/master

Balint Reczey balint.reczey at canonical.com
Thu May 16 15:35:06 UTC 2019



Diff comments:

> diff --git a/live-build/ubuntu-cpc/hooks.d/base/wsl.binary b/live-build/ubuntu-cpc/hooks.d/base/wsl.binary
> new file mode 100755
> index 0000000..97243cb
> --- /dev/null
> +++ b/live-build/ubuntu-cpc/hooks.d/base/wsl.binary
> @@ -0,0 +1,49 @@
> +#!/bin/bash -eux
> +# vi: ts=4 expandtab
> +#
> +# Generate the compressed root directory for WSL
> +
> +case ${SUBPROJECT:-} in
> +    minimized)
> +        echo "Skipping minimized $0 build as WSL systems are designed to be interactive"
> +        exit 0
> +        ;;
> +    *)
> +        ;;
> +esac
> +
> +case $ARCH in
> +    amd64|arm64)
> +        ;;
> +    *)
> +        echo "WSL root tarballs are not generated for $ARCH."
> +        exit 0;;
> +esac
> +
> +if [ -n "${SUBARCH:-}" ]; then
> +    echo "Skipping rootfs build for subarch flavor build"
> +    exit 0
> +fi
> +
> +. config/functions
> +
> +rootfs_dir=wslroot.dir
> +
> +# This is the directory created by create-root-dir.binary
> +cp -a rootfs.dir $rootfs_dir
> +
> +setup_mountpoint $rootfs_dir
> +
> +env DEBIAN_FRONTEND=noninteractive chroot $rootfs_dir apt-get -y -qq install ubuntu-wsl
> +
> +create_manifest $rootfs_dir livecd.ubuntu-cpc.wsl.rootfs.manifest
> +teardown_mountpoint $rootfs_dir
> +
> +# remove attributes not supported by WSL's tar
> +if [ -d $rootfs_dir/var/log/journal ]; then
> +    setfattr -x system.posix_acl_access $rootfs_dir/var/log/journal
> +    setfattr -x system.posix_acl_default $rootfs_dir/var/log/journal
> +fi
> +
> +pushd $rootfs_dir
> +tar --xattrs --sort=name -czf ../livecd.ubuntu-cpc.wsl.rootfs.tar.gz *

In general I don't like bashism either but pushd was already used in disk-image.binary, thus I felt it was ok.

tar ... -czf .. -C dir * because * is expanded first by bash thus it would not work.



-- 
https://code.launchpad.net/~rbalint/livecd-rootfs/+git/livecd-rootfs/+merge/367293
Your team Ubuntu Core Development Team is subscribed to branch livecd-rootfs:ubuntu/master.



More information about the Ubuntu-reviews mailing list