[Merge] lp:~khurshid-alam/indicator-appmenu/ignore-desktop into lp:indicator-appmenu

Khurshid Alam khurshid.alam at linuxmail.org
Mon May 6 14:34:24 UTC 2019


Khurshid Alam has proposed merging lp:~khurshid-alam/indicator-appmenu/ignore-desktop into lp:indicator-appmenu with lp:~khurshid-alam/indicator-appmenu/fix-build-disco as a prerequisite.

Commit message:
* Don't use the deprecated g_type_class_add_private

* Use X11 specific error trap functions

* Do not to track menus for desktop_windows. Fixes LP:#1827411

Requested reviews:
  Marco Trevisan (TreviƱo) (3v1n0)

For more details, see:
https://code.launchpad.net/~khurshid-alam/indicator-appmenu/ignore-desktop/+merge/366990

Bamf somehow not considering desktop window as valid bamf window (see https://paste.ubuntu.com/p/wz32KF7Kqx/). As a result when indicator-appmenu tries to track menu it fails. For now we are ignoring tracking desktop windows in indicator-appmenu.
-- 
Your team Indicator Applet Developers is subscribed to branch lp:indicator-appmenu.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 4504 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20190506/f77d93ca/attachment.diff>


More information about the Ubuntu-reviews mailing list