[Bug 1826413] Re: ALSA Jack Midi bridge off selection not surviving a reboot

Steve Langasek steve.langasek at canonical.com
Fri May 3 23:32:37 UTC 2019


-    self.usb_plug_check.set_active(self.usb)
+    if self.usb == "True":
+        self.usb_plug_check.set_active(True)
+    elif self.usb == "False":
+        self.usb_plug_check.set_active(False)


I think this could be instead written as

    self.usb_plug_check.set_active(self.usb == "True")

to cast from a string to a boolean (unless you expect there to be other
possible values besides "True" and "False")

would you want to make this change in devel and reupload to the queue?

-- 
You received this bug notification because you are a member of Ubuntu
Studio Development, which is subscribed to ubuntustudio-controls in
Ubuntu.
https://bugs.launchpad.net/bugs/1826413

Title:
  ALSA Jack Midi bridge off selection not surviving a reboot

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntustudio-controls/+bug/1826413/+subscriptions



More information about the Ubuntu-reviews mailing list