[Merge] ~rcj/livecd-rootfs/+git/livecd-rootfs:ubuntu/disco_parallel_cpc_fixes into livecd-rootfs:ubuntu/disco

Robert C Jennings robert.jennings at canonical.com
Thu May 2 21:21:24 UTC 2019


Robert C Jennings has proposed merging ~rcj/livecd-rootfs/+git/livecd-rootfs:ubuntu/disco_parallel_cpc_fixes into livecd-rootfs:ubuntu/disco.

Commit message:
ubuntu-cpc: Ensure base disk image is the same between all build targets

The following targets have livecd.ubuntu-cpc.manifest (and
livecd.ubuntu-cpc.ext4) which differ in some way from the 'all'
target. They are all missing grub-efi and other modifications:

root-dir
squashfs
tarball

These targets do not depend on the 'disk-image' target. This means that
the ext4 produced will lack the uefi modifications (and any from the
disk-image target binary hooks).

Since the ext4 file is common to all builds there is a chance that a
parallel build from one of these targets could overwrite this artifact.

Requested reviews:
  Ubuntu Core Development Team (ubuntu-core-dev)

For more details, see:
https://code.launchpad.net/~rcj/livecd-rootfs/+git/livecd-rootfs/+merge/366863
-- 
Your team Ubuntu Core Development Team is requested to review the proposed merge of ~rcj/livecd-rootfs/+git/livecd-rootfs:ubuntu/disco_parallel_cpc_fixes into livecd-rootfs:ubuntu/disco.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 4042 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20190502/08517a4a/attachment-0001.diff>


More information about the Ubuntu-reviews mailing list