[Merge] ~rbalint/ubuntu-seeds/+git/platform:disco into ~ubuntu-core-dev/ubuntu-seeds/+git/platform:disco

Colin Watson cjwatson at canonical.com
Wed Mar 6 10:35:58 UTC 2019


Review: Needs Fixing

I have no opinion on the seed contents, but here are a couple of structural comments.

Diff comments:

> diff --git a/STRUCTURE b/STRUCTURE
> index ca47542..9b03605 100644
> --- a/STRUCTURE
> +++ b/STRUCTURE
> @@ -4,6 +4,7 @@ required:
>  minimal: required
>  boot:
>  standard: minimal
> +wsl:

This should inherit from the "required" seed.

>  desktop-common: standard
>  d-i-requirements: minimal
>  installer:
> diff --git a/wsl b/wsl
> new file mode 100644
> index 0000000..d1f91a0
> --- /dev/null
> +++ b/wsl
> @@ -0,0 +1,38 @@
> +Packages needed or useful in WSL installations

Explain what this is in the header text rather than just restating the initialism.

> +
> +== Comfortable Unix System ==
> +
> +Programs and packages necessary for both the proper functionality of the system and that any user would expect to find on a modern Unix-like system.
> +
> + * adduser
> + * apt
> + * apt-utils         # apt-extracttemplates is required for debconf preconfiguration
> + * bzip2
> + * debconf-i18n      # buildd chroots don't need this, but other systems generally do
> + * less
> + * locales
> + * lsb-release
> + * netbase
> + * python3           # explicitly seeded, despite lsb-release also pulling it it
> + * (rsyslog)
> + * sudo              # LaMontJones
> + * sysvinit-utils    # until "pidof" moves into procps, Debian #810018
> + * tzdata
> + * ubuntu-advantage-tools # needs to be on the system by default for ESM
> + * ubuntu-keyring     # for authenticated package downloads
> + * udev
> + * vim-tiny
> + * whiptail          # for debconf's Dialog frontend
> +
> +== Networking ==
> +
> +These provide various networking services, all should be configured in a client-only state with the server de-activated unless the user requires it.
> +
> + * isc-dhcp-client   # LaMontJones
> + * iproute2
> + * iputils-ping
> + * netcat-openbsd # FabioMassimoDiNitto
> +
> += Meta =
> +
> + * ubuntu-wsl     # Ubuntu-specific bits we want on every Ubuntu WSL system


-- 
https://code.launchpad.net/~rbalint/ubuntu-seeds/+git/platform/+merge/364003
Your team Ubuntu Core Development Team is requested to review the proposed merge of ~rbalint/ubuntu-seeds/+git/platform:disco into ~ubuntu-core-dev/ubuntu-seeds/+git/platform:disco.



More information about the Ubuntu-reviews mailing list