[Merge] ~ken-vandine/ubuntu-seeds/+git/ubuntu:eoan into ~ubuntu-core-dev/ubuntu-seeds/+git/ubuntu:eoan

Iain Lane iain at orangesquash.org.uk
Fri Jul 12 15:35:07 UTC 2019


Review: Needs Fixing

I think livecd-rootfs is supposed to handle this, isn't it? This is effectively a revert of Łukasz's change here:

commit 6f3707c8dd8fdc7c4c0ca1eeff428fa0e4678db6
Author: Łukasz 'sil2100' Zemczak <lukasz.zemczak at canonical.com>
Date:   Mon Apr 15 11:13:03 2019 +0200

    Remove the core18 snap from the seeds as it should now be pulled in implicitly by livecd-rootfs (by the logic of pulling in bases of snaps).

so it sounds to me like we should not be changing the seeds to fix this problem, but finding out what went wrong in livecd-rootfs and fixing that. Do you agree?
-- 
https://code.launchpad.net/~ken-vandine/ubuntu-seeds/+git/ubuntu/+merge/370062
Your team Ubuntu Core Development Team is subscribed to branch ~ubuntu-core-dev/ubuntu-seeds/+git/ubuntu:eoan.



More information about the Ubuntu-reviews mailing list