[Merge] ~cjwatson/livecd-rootfs:bionic/buildd into livecd-rootfs:ubuntu/bionic
Ćukasz Zemczak
lukasz.zemczak at canonical.com
Thu Jan 24 13:40:36 UTC 2019
Content-wise it looks sane, so +1 on it in overall.
There's one thing in these changes for what I have been yelled at by Adam when I proposed something similar: as per what Adam said, livecd-rootfs changes by principle should not do anything conditionally 'per suite'. I've been told that if there's something that needs to be done in, say, bionic and not in xenial, then the bionic branch should have the changes but the xenial one not etc.
I also do some per-suite operations as I didn't want to have to introduce a different delta for each series (for the ubuntu-core work). But I've been told that it's not 'the right way'.
So just mentioning it here. I don't particularly mind, so treat it as a +1 from me anyway.
--
https://code.launchpad.net/~cjwatson/livecd-rootfs/+git/livecd-rootfs/+merge/361825
Your team Ubuntu Core Development Team is requested to review the proposed merge of ~cjwatson/livecd-rootfs:bionic/buildd into livecd-rootfs:ubuntu/bionic.
More information about the Ubuntu-reviews
mailing list