[Merge] lp:~khurshid-alam/indicator-sound/gicon-regression-fix into lp:indicator-sound
Sebastien Bacher
seb128 at ubuntu.com
Tue Feb 12 08:49:17 UTC 2019
Review: Needs Fixing
Thank you for your work, unsure the glib behaviour change can be described as 'regression' and that they plan to change the behaviour though. The test here should be adapted rather than commented out (and if you do you need to comment them, then there should at least be a code comment describing what needs to be fixed/changed later)
--
https://code.launchpad.net/~khurshid-alam/indicator-sound/gicon-regression-fix/+merge/363041
Your team Indicator Applet Developers is subscribed to branch lp:indicator-sound.
More information about the Ubuntu-reviews
mailing list