[Merge] ~andrew.sh/unity:fix-auth-failure-lp1733557 into unity:master

Andrej Shadura andrewsh at debian.org
Tue Feb 5 11:08:44 UTC 2019



Diff comments:

> diff --git a/lockscreen/UserAuthenticatorPam.cpp b/lockscreen/UserAuthenticatorPam.cpp
> index 463d8f9..8fad03a 100644
> --- a/lockscreen/UserAuthenticatorPam.cpp
> +++ b/lockscreen/UserAuthenticatorPam.cpp
> @@ -46,6 +46,8 @@ bool UserAuthenticatorPam::AuthenticateStart(std::string const& username,
>    if (pam_handle_)
>    {
>      LOG_ERROR(logger) << "Unable to start authentication because another one has already been started";
> +    pam_end(pam_handle_, PAM_TRY_AGAIN);

I don’t have a strong opinion on this, but sure, why not.

> +    pam_handle_ = nullptr;
>      return false;
>    }
>  


-- 
https://code.launchpad.net/~andrew.sh/unity/+git/unity/+merge/362414
Your team Unity Team is requested to review the proposed merge of ~andrew.sh/unity:fix-auth-failure-lp1733557 into unity:master.



More information about the Ubuntu-reviews mailing list