[Merge] ~andrew.sh/unity:fix-auth-failure-lp1733557 into unity:master

[Andrea Azzarone]

Review: Needs Fixing



Diff comments:

> diff --git a/lockscreen/UserAuthenticatorPam.cpp b/lockscreen/UserAuthenticatorPam.cpp
> index 463d8f9..8fad03a 100644
> --- a/lockscreen/UserAuthenticatorPam.cpp
> +++ b/lockscreen/UserAuthenticatorPam.cpp
> @@ -46,6 +46,8 @@ bool UserAuthenticatorPam::AuthenticateStart(std::string const& username,
>    if (pam_handle_)
>    {
>      LOG_ERROR(logger) << "Unable to start authentication because another one has already been started";
> +    pam_end(pam_handle_, PAM_TRY_AGAIN);

First of all, thanks for the fix! 

>From pam_end documentation [1]:

> The pam_status argument should be set to the value returned to the application by the last PAM library call. 

I think we should do this pam_end(pam_handle_, this->_status); Wdyt?

[1] https://linux.die.net/man/3/pam_end

> +    pam_handle_ = nullptr;
>      return false;
>    }
>  


-- 
https://code.launchpad.net/~andrew.sh/unity/+git/unity/+merge/362414
Your team Unity Team is requested to review the proposed merge of ~andrew.sh/unity:fix-auth-failure-lp1733557 into unity:master.