[Merge] lp:~rbalint/ubuntu-release-upgrader/ubuntu-release-upgrader into lp:ubuntu-release-upgrader

Brian Murray brian at ubuntu.com
Fri Dec 6 19:37:15 UTC 2019


Review: Needs Fixing

I believe there is a mistake in this merge.

Diff comments:

> 
> === modified file 'debian/release-upgrade-motd'
> --- debian/release-upgrade-motd	2013-05-07 15:39:09 +0000
> +++ debian/release-upgrade-motd	2019-12-05 17:08:46 +0000
> @@ -34,7 +34,7 @@
>  		cat "$stamp"
>  		echo
>  	fi
> -else
> +elif [ "(id -u)" = 0 ]; then

While I'm a manager now I still know you are missing a $ here.

>  	# No cache at all, so update in the background
>  	/usr/lib/ubuntu-release-upgrader/check-new-release -q > "$stamp" &
>  fi


-- 
https://code.launchpad.net/~rbalint/ubuntu-release-upgrader/ubuntu-release-upgrader/+merge/376424
Your team Ubuntu Core Development Team is requested to review the proposed merge of lp:~rbalint/ubuntu-release-upgrader/ubuntu-release-upgrader into lp:ubuntu-release-upgrader.



More information about the Ubuntu-reviews mailing list