[Merge] lp:~sil2100/ubuntu-release-upgrader/snap-size-estimation into lp:ubuntu-release-upgrader

Ɓukasz Zemczak lukasz.zemczak at canonical.com
Fri Aug 9 13:19:18 UTC 2019


>From the stylistic nitpicks for instance, I really had a strong urge to just call _prepare_snap_replacement_data() in both _calculateSnapSizeRequirements() and _replaceDebsWithSnaps(), and simply make it to exit early if self._snap_list is already non-empty. But then it would be non-optimal, since we know _replaceDebsWithSnaps will never be called without _calculateSnapSizeRequirements running first. But eh, I somehow couldn't make this look pretty, sorry...
-- 
https://code.launchpad.net/~sil2100/ubuntu-release-upgrader/snap-size-estimation/+merge/371120
Your team Ubuntu Core Development Team is requested to review the proposed merge of lp:~sil2100/ubuntu-release-upgrader/snap-size-estimation into lp:ubuntu-release-upgrader.



More information about the Ubuntu-reviews mailing list