[Merge] ~mwhudson/livecd-rootfs/+git/livecd-rootfs:no-snaps-ubuntu-cpc-minimized into livecd-rootfs:ubuntu/master

[Robert C Jennings]

Diff comments:

> diff --git a/live-build/auto/config b/live-build/auto/config
> index 2626229..2896470 100755
> --- a/live-build/auto/config
> +++ b/live-build/auto/config
> @@ -895,6 +895,22 @@ esac
>  if [ "$PASSES_TO_LAYERS" != "true" ] && [ -n "${BASE_SEED}" ]; then
>  	snap_from_seed "${BASE_SEED}" config/seeded-snaps
>  fi
> +if [ "$PROJECT:${SUBPROJECT:-}" = ubuntu-cpc:minimized ]; then
> +	# We install a lxc script that installs the snap when invoked. We don't
> +	# want any other snaps to come in without due consideration, so fail the
> +	# build if we see such a snap.
> +	for snap in `cat config/seeded-snaps`; do
> +		case $snap in
> +			lxd)
> +				;;
> +			*)
> +				echo "Unexpected seeded snap for ubuntu-cpc:minimized build: $snap"
> +				exit 1
> +				;;
> +		esac
> +	done
> +	rm config/seeded-snaps

I think there is some confusion that stems from discussing this elsewhere as 'removing the lxd snap' with respect to first boot impacts.

LXD gets singled out because it is the first, and only, seeded snap for ubuntu-server and present in all ubuntu-cpc images.  But the image size and first boot speed impact is due to preseeding LXD *and* the core snap.  When the first snap is pre-seeded we need to pull in the core snap; as we need to have a core snap for basic functionality.  But when the only snap is skipped, the core snap should not be present.

Any derived image that might want to preseed its own snaps should be checked (for minimal images) to ensure it is coded properly to pull in the core snap as, lxd will not be present to save the developer that got it wrong.

> +fi
>  
>  # grab a list of packags to remove for a "minimal" installation from the seed
>  # mirror for this project


-- 
https://code.launchpad.net/~mwhudson/livecd-rootfs/+git/livecd-rootfs/+merge/364222
Your team Ubuntu Core Development Team is subscribed to branch livecd-rootfs:ubuntu/master.