[Merge] lp:~brian-murray/ubuntu-release-upgrader/better-uri-testing into lp:ubuntu-release-upgrader

[Brian Murray]

Brian Murray has proposed merging lp:~brian-murray/ubuntu-release-upgrader/better-uri-testing into lp:ubuntu-release-upgrader.

Requested reviews:
  Ubuntu Core Development Team (ubuntu-core-dev)

For more details, see:
https://code.launchpad.net/~brian-murray/ubuntu-release-upgrader/better-uri-testing/+merge/365494

As a part of improving the release upgrade process for people with PPAs enabled a check was added to see if the release to which we are upgrading is provided by the archive (LP: #1807043). However, this check is done for every entry and its uri in a sources.list file which could result in a situation, if a network was flakey, where main was enabled and universe was not (LP: #1822886).

If we instead have a dictionary of the entry.uris and whether or not they were accessible all the sources.list entries with that uri will be disabled. In the case of the Ubuntu archive this will result in 'ubuntu-minimal' not being downloadable and the upgrade process will abort. This is better than the upgrade proceeding and some components for an archive being disabled. Additionally, the multiple calls to _sourcesListEntryDownloadable were unnecessary.
-- 
Your team Ubuntu Core Development Team is requested to review the proposed merge of lp:~brian-murray/ubuntu-release-upgrader/better-uri-testing into lp:ubuntu-release-upgrader.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 2660 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20190403/38fa1986/attachment.diff>