[Merge] ~slashd/ubuntu/+source/horizon:lp1822129 into ~ubuntu-server-dev/ubuntu/+source/horizon:master

[Eric Desrochers]

Eric Desrochers has proposed merging ~slashd/ubuntu/+source/horizon:lp1822129 into ~ubuntu-server-dev/ubuntu/+source/horizon:master.

Commit message:
Not implicitly set vol_device_name to vda
 Using a scsi decorated image with:
 hw_disk_bus='scsi'
 hw_scsi_model='virtio-scsi'

 This solve the case where an instance is
 launched with 'image' selected as boot
 source with a new volume. This will result
 in /dev/vda instead of /dev/sda as it
 should.

 Not specifying device name in
 setFinalSpecBootImageToVolume() leaves the
 decision to nova to determine it.

 Example:
 -------
 VM boot volume without scsi meta data decoration:
 Attached To
 0a0cd660-7ce3-4033-9983-2e1099edc5f0 on /dev/vda

 VM boot volume with scsi meta data decoration:
 Attached To
 91f50dbc-8bdf-4293-84ea-fc5df27b5ee4 on /dev/sda
 --------

 Note: This commit doesn't address cases for
 where instances are launched using existing
 volume and snapshot, this will involve more
 work to migrate the code from BDMv1 to BDMv2.

 Closes-Bug #1560965

 Change-Id: I9d114c2c2e6736a8f1a8092afa568f930b656f09

Requested reviews:
  Corey Bryant (corey.bryant)

For more details, see:
https://code.launchpad.net/~slashd/ubuntu/+source/horizon/+git/horizon/+merge/365364

d/p/drop-devicename-creating-server-with-image-boot-to-volume.patch:
When creating a server using an image boot source to new volume,
horizon specified device_name 'vda'. If for instance we use an image
with disk_bus type scsi, horizon will name the device_name as 'vda'
when it should be 'sda'. As per BDMv2 documentation, it's best to not
specify device_name. (LP: #1822129)
-- 
Your team Ubuntu Server Developers is subscribed to branch ~ubuntu-server-dev/ubuntu/+source/horizon:master.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 7002 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20190401/2f295dbc/attachment.diff>