[Merge] lp:~tobijk/livecd-rootfs/image-sets into lp:livecd-rootfs
Tobias Koch
tobias.koch at canonical.com
Thu Oct 18 08:34:33 UTC 2018
Tobias Koch has proposed merging lp:~tobijk/livecd-rootfs/image-sets into lp:livecd-rootfs.
Commit message:
Use series files with dependency handling to generate hook symlinks dynamically
This patch currently only applies to the "ubuntu-cpc" project.
More and more logic has been going into the hook scripts to decide under which conditions they should run or not. As we are moving to parallelized builds of image sets, this will get even more complicated. Base hooks will have to know which image sets they belong to and modification of the dependency chain between scripts will become more complicated and prone to errors, as the number of image sets grows.
This patch introduces explicit ordering and dependency handling for scripts through the use of `series` files and an explicit syntax for dependency specification.
Requested reviews:
Canonical Cloudware (cloudware)
Ubuntu Core Development Team (ubuntu-core-dev)
For more details, see:
https://code.launchpad.net/~tobijk/livecd-rootfs/image-sets/+merge/356246
Please read
https://bazaar.launchpad.net/~tobijk/livecd-rootfs/image-sets/view/head:/live-build/ubuntu-cpc/README.cpc.md
In order to try out the hook generation, change to
live-build/ubuntu-cpc/hooks.d
and call `make-hooks` with different arguments, for example:
./make-hooks --hooks-dir hook-test vagrant
or
./make-hooks --hooks-dir hook-test squashfs disk-image vagrant
Take a look at hooks.d/base/series for available series files.
--
Your team Ubuntu Core Development Team is requested to review the proposed merge of lp:~tobijk/livecd-rootfs/image-sets into lp:livecd-rootfs.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 18713 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20181018/6775c26b/attachment.diff>
More information about the Ubuntu-reviews
mailing list