[Merge] lp:~codyshepherd/livecd-rootfs/uefi-manifests-bionic into lp:~ubuntu-core-dev/livecd-rootfs/bionic-proposed

Francis Ginther francis.ginther at canonical.com
Mon Nov 26 18:15:29 UTC 2018


One comment on the version, otherwise this looks good.

Diff comments:

> === modified file 'debian/changelog'
> --- debian/changelog	2018-11-16 16:41:04 +0000
> +++ debian/changelog	2018-11-26 17:49:36 +0000
> @@ -1,12 +1,13 @@
> -livecd-rootfs (2.525.10) UNRELEASED; urgency=medium
> +livecd-rootfs (2.525.10ubuntu1) UNRELEASED; urgency=medium

Please drop the "ubuntu1", so that we keep the version at 2.525.10. This has not been successfully uploaded yet (it's stuck in the queue and I expect a fresh upload containing this MP to replace it).

>  
>    [ Cody Shepherd ]
>    * Include grub efi packages in manifests for uefi images.
> +    (LP: #1805190)
>  
>    [ Robert C Jennings ]
>    * Disable checksum generation (LP: #1799773)
>  
> - -- Cody Shepherd <cody.shepherd at canonical.com>  Fri, 26 Oct 2018 15:01:07 -0600
> + -- Cody Shepherd <cody.shepherd at canonical.com>  Mon, 26 Nov 2018 09:47:22 -0800
>  
>  livecd-rootfs (2.525.9) bionic; urgency=medium
>  


-- 
https://code.launchpad.net/~codyshepherd/livecd-rootfs/uefi-manifests-bionic/+merge/359550
Your team Ubuntu Core Development Team is requested to review the proposed merge of lp:~codyshepherd/livecd-rootfs/uefi-manifests-bionic into lp:~ubuntu-core-dev/livecd-rootfs/bionic-proposed.



More information about the Ubuntu-reviews mailing list