[Merge] lp:~daniel-thewatkins/livecd-rootfs/trunk into lp:livecd-rootfs

[Robert C Jennings]

Review: Needs Fixing

I'd like to see a comment added somewhere... details in the diff below

Diff comments:

> 
> === added file 'live-build/ubuntu-cpc/hooks/031-root-xz.binary'
> --- live-build/ubuntu-cpc/hooks/031-root-xz.binary	1970-01-01 00:00:00 +0000
> +++ live-build/ubuntu-cpc/hooks/031-root-xz.binary	2018-06-06 18:24:30 +0000
> @@ -0,0 +1,30 @@
> +#!/bin/bash -ex
> +# vi: ts=4 expandtab
> +#
> +# Generate the rootfs.tar.xz and manifest
> +
> +if [ -n "$SUBARCH" ]; then
> +    echo "Skipping rootfs build for subarch flavor build"
> +    exit 0
> +fi
> +
> +. /build/config/functions
> +
> +tardir=filesystem.dir
> +mkdir $tardir
> +cp -a chroot/* $tardir
> +
> +setup_mountpoint $tardir
> +
> +env DEBIAN_FRONTEND=noninteractive chroot $tardir apt-get --purge remove --assume-yes '^linux-.*' 'linux-base+'
> +env DEBIAN_FRONTEND=noninteractive chroot $tardir apt-get --purge remove --assume-yes '^grub-.*'
> +env DEBIAN_FRONTEND=noninteractive chroot $tardir apt-get autoremove --purge --assume-yes
> +chroot $tardir mkdir -p /lib/modules

As this file is coming in as a single commit without history I would like you to capture rationale behind this "magic" line.  I've searched the bzr log and found the commit message for this line in xenial's root-tarball, can you include this either in the file or commit message?
---
ubuntu-cpc: in hooks/030-root-tarball.binary create /lib/modules to fix
(LP: 1543204).

This allows kernel + initramfs + cloud-initramfs-copymods to use the lxd
image.  Without /lib/modules present the cloud-initramfs-copymods
initramfs module will not be able to populate /lib/modules/<uname -r>.

> +
> +teardown_mountpoint $tardir
> +
> +dpkg-query --admindir=$tardir/var/lib/dpkg -W > livecd.ubuntu-cpc.rootfs.manifest
> +
> +(cd "$tardir/" && tar -c *) | xz > "livecd.ubuntu-cpc.rootfs.tar.xz"
> +
> +rm -rf $tardir


-- 
https://code.launchpad.net/~daniel-thewatkins/livecd-rootfs/trunk/+merge/347547
Your team Ubuntu Core Development Team is requested to review the proposed merge of lp:~daniel-thewatkins/livecd-rootfs/trunk into lp:livecd-rootfs.