[Merge] lp:~rcj/livecd-rootfs/livecd-rootfs into lp:livecd-rootfs
Robert C Jennings
robert.jennings at canonical.com
Tue Apr 3 15:04:43 UTC 2018
> live-build/auto/config does already call live-build/functions. No problem
> there.
Okay, so I'll try to rip that out of live-build/auto/build and call these new functions. The delta will be on xenial where we have live-build/ubuntu-cpc/functions instead of live-build/functions.
> We should be series 16 for now on both xenial and bionic as that is the only
> series there is that we can use. There is no core18 snap yet in the store
> that we can reference.
>
> The code for pulling the 'account' variable is correct, but for some reason
> the existing code doesn't use it, instead using a hard-coded 'snap known
> --remote account account-id=generic'. Seems like that was a thinko on my part
> when merging in existing code.
Should it then be this...
snap known --remote account account-id=$account
--
https://code.launchpad.net/~rcj/livecd-rootfs/livecd-rootfs/+merge/342554
Your team Ubuntu Core Development Team is requested to review the proposed merge of lp:~rcj/livecd-rootfs/livecd-rootfs into lp:livecd-rootfs.
More information about the Ubuntu-reviews
mailing list