[Merge] lp:~sil2100/update-manager/fix-test-failure-origin into lp:update-manager

[Łukasz Zemczak]

Łukasz Zemczak has proposed merging lp:~sil2100/update-manager/fix-test-failure-origin into lp:update-manager.

Commit message:
Fix the testOriginMatcherWithVersionInUpdatesAndSecurity test as it was making wrong assumptions, not checking if packages actually had ANY package in -security.

Requested reviews:
  Ubuntu Core Development Team (ubuntu-core-dev)

For more details, see:
https://code.launchpad.net/~sil2100/update-manager/fix-test-failure-origin/+merge/330446

Fix the testOriginMatcherWithVersionInUpdatesAndSecurity test as it was making wrong assumptions, not checking if packages actually had ANY package in -security.

The test was supposed to check the case of when there's an update in -updates that's higher version than in -security. There is a check to make sure we're not adding packages to the test set if they have the same version in both -updates and -security, but things start to fail if a package has a more than 2 versions in xenial and none in -security. e.g. in the case of having 3 versions, one in xenial and 2 in xenial-updates, the package was instantly marked as 'good' for the test case. And the test is failing as it fails to mark the package as having a security update - since it doesn't have one.

Solution: when choosing packages to be used in the test, let's check if there is ANY version in -security. Otherwise it makes no sense to try and use the package for testing. This test-case seemed to work by sheer luck before.
-- 
Your team Ubuntu Core Development Team is requested to review the proposed merge of lp:~sil2100/update-manager/fix-test-failure-origin into lp:update-manager.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 1378 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20170908/663f9300/attachment.diff>