[Merge] lp:~sil2100/dbus-cpp/fix_ftbfs into lp:dbus-cpp

Łukasz Zemczak lukasz.zemczak at canonical.com
Tue Oct 31 19:10:44 UTC 2017


Łukasz Zemczak has proposed merging lp:~sil2100/dbus-cpp/fix_ftbfs into lp:dbus-cpp.

Commit message:
Fix FTBFS on bionic by switching to use cmake-extras and not enforcing -pedantic anymore as current gtest macros do not follow strict standards anymore.

Requested reviews:
  Ubuntu Phablet Team (phablet-team)

For more details, see:
https://code.launchpad.net/~sil2100/dbus-cpp/fix_ftbfs/+merge/333049

Fix FTBFS on bionic by switching to use cmake-extras and not enforcing -pedantic anymore as current gtest macros do not follow strict standards anymore.

Using -pedantic doesn't make sense for a project that is not actively maintained anymore anyway.
-- 
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~sil2100/dbus-cpp/fix_ftbfs into lp:dbus-cpp.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 5163 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20171031/ca3438ca/attachment.diff>


More information about the Ubuntu-reviews mailing list