[Merge] lp:~mwhudson/livecd-rootfs/bug-1711735 into lp:~ubuntu-core-dev/livecd-rootfs/trusty-proposed

[Michael Hudson-Doyle]

Michael Hudson-Doyle has proposed merging lp:~mwhudson/livecd-rootfs/bug-1711735 into lp:~ubuntu-core-dev/livecd-rootfs/trusty-proposed.

Requested reviews:
  Ubuntu Core Development Team (ubuntu-core-dev)
Related bugs:
  Bug #1711735 in cloud-images: "source.list for armhf includes trusty-security which does not exist for arm"
  https://bugs.launchpad.net/cloud-images/+bug/1711735

For more details, see:
https://code.launchpad.net/~mwhudson/livecd-rootfs/bug-1711735/+merge/333005

Turns out this is super simple, just copy the fix from trunk.

Testing is a bit more involved of course.

I created my own copy of the ~cloud-images-release-managers/+livefs/ubuntu/trusty/docker-ubuntu-core livefs at https://launchpad.net/~mwhudson/+livefs/ubuntu/trusty/docker-ubuntu-core-tests, uploaded a version of livecd-rootfs with no changes to ppa:mwhudson/scratch, built a amd64 and armhf image, checked they were using the right livecd-rootfs, uploaded a version of livecd-rootfs with the change from this branch to the same ppa and built amd64 and armhf again.

I then diffed the pre and post fix tarballs and confirmed that there are no meaningful changes in amd64 ("http://security.ubuntu.com/ubuntu" has become "http://security.ubuntu.com/ubuntu/" in the sources.list) and that the changes we wanted to see are in the armhf tarballs. I also tested apt update in the armhf tarballs via qemu-arm-static and it now succeeds.

If you want to check my working I've uploaded the pre and post fix tarballs to http://people.canonical.com/~mwh/bug-1711735/

-- 
Your team Ubuntu Core Development Team is requested to review the proposed merge of lp:~mwhudson/livecd-rootfs/bug-1711735 into lp:~ubuntu-core-dev/livecd-rootfs/trusty-proposed.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 1777 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20171030/5b024555/attachment.diff>