[Merge] lp:~phablet-team/telephony-service/qml-start-chat into lp:telephony-service/staging

Gustavo Pichorim Boiko gustavo.boiko at canonical.com
Tue Mar 21 17:54:42 UTC 2017


Review: Needs Fixing

Just one request.

Diff comments:

> 
> === modified file 'libtelephonyservice/accountlist.h'
> --- libtelephonyservice/accountlist.h	2016-10-04 02:47:27 +0000
> +++ libtelephonyservice/accountlist.h	2017-03-03 17:50:47 +0000
> @@ -55,10 +55,12 @@
>      void allAccountsChanged();
>      void activeAccountsChanged();
>      void displayedAccountsChanged();
> +    void accountChanged(AccountEntry *entry, bool active);
>  
>  protected Q_SLOTS:
>      void init();
>      void filterAccounts();
> +    void activeAccountsChangedImpl();

Can you just rename it to onActiveAccountChanged() to be consistent with the other slot names?

>  
>  private:
>      Protocol::Features mFeatures;


-- 
https://code.launchpad.net/~phablet-team/telephony-service/qml-start-chat/+merge/317494
Your team Ubuntu Phablet Team is subscribed to branch lp:~phablet-team/telephony-service/add-participants-model.



More information about the Ubuntu-reviews mailing list