[Merge] lp:~tdaitx/location-service/lp-1640320-ftbfs-fix into lp:location-service/trunk

[Tiago Stürmer Daitx]

Tiago Stürmer Daitx has proposed merging lp:~tdaitx/location-service/lp-1640320-ftbfs-fix into lp:location-service/trunk.

Requested reviews:
  Ubuntu Phablet Team (phablet-team)

For more details, see:
https://code.launchpad.net/~tdaitx/location-service/lp-1640320-ftbfs-fix/+merge/319636

Fix location-service FTBFS on zesty, mainly tracked on LP: #

There are 2 compound causes for the FTBFS:
1. googletest update that caused cmake errors
2. missing vector includes that caused undefined reference errors

== googletest update issues ==
The googletest updated error is better described on LP: #1644062. The same fix applied to cmake-extras [1] (see comment #3 [2]) allows to detect and set the right paths for gtest and gmock, but then it runs into the same problem as comment #7 [3] which again causes the build to fail because dh_install complains about the extra files installed by googletest. This issue is better described by the commit that introduced the googletest install clause [4] and the comments there indicate that bundling googletest is not recomended - it should instead be added as an external project. This is exactly the approach taken by GMockConfig.make [5] file in cmake-extras does. The proposed solution for the first part of the FTBFS fix is to rely on that to properly reference and include both gtest and gmock.

== missing vector includes ==
The missing includes for vector causes yet another FTBFS. The includes used in this merge are simple a suggestion, I'm not familiar with location-service code so it is very likely that there is a better place to put those (or even use a different include).

[1] https://code.launchpad.net/~michihenning/cmake-extras/gtest-fixes/+merge/311565
[2] https://bugs.launchpad.net/ubuntu/+source/googletest/+bug/1644062/comments/3
[3] https://bugs.launchpad.net/ubuntu/+source/googletest/+bug/1644062/comments/7
[4] https://github.com/google/googletest/commit/98d988deac06637364f6cd41c45c3db4a8a0b6bc
[5] http://bazaar.launchpad.net/~cmake-extras/cmake-extras/trunk/view/head:/src/GMock/GMockConfig.cmake
-- 
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~tdaitx/location-service/lp-1640320-ftbfs-fix into lp:location-service/trunk.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 3275 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20170311/239e8664/attachment.diff>