[Merge] lp:~jonas-drange/ubuntu-ui-extras/copies into lp:~phablet-team/ubuntu-ui-extras/printer-staging

[Andrew Hayzen]

Review: Needs Fixing

OK, so I looked into what other apps do for this case they all do this currently:
default=5  gui=1  result=5
default=5  gui=2  result=2

This is incredibly confusing, we can do better, as discussed these are our options:
1) Load the default for the printer when PrinterJob is created
2) Load the default each time the printer changes
3) Load the default when the printer is set and the value of copies is the same as the default of the previous printer

Option #1: isn't very useful (only useful if the default printer has a defaultCopies value)
Option #2: is confusing to the user, if they set the copies to a non-default and then change the printer this will result in their value being lost
Option #3: only has one edge case where this could be confusing.

As discussed could you implement option #3.

Also for this to work in backend_cups there is the following code:
    if (options->copies() > 1) {
        __CUPS_ADD_OPTION(dest, "copies", QString::number(options->copies()).toLocal8Bit());
    }
This needs to be changed to if copies > 0, maybe we need to think of the else case as well (if a copies value of 0 or less is given should we set copies=1 or leave it blank so cups sets the default?)
-- 
https://code.launchpad.net/~jonas-drange/ubuntu-ui-extras/copies/+merge/319099
Your team Ubuntu Phablet Team is subscribed to branch lp:~phablet-team/ubuntu-ui-extras/printer-staging.