[Merge] lp:~gunnarhj/ubuntu-seeds/ubuntu.artful_lang-support into lp:~ubuntu-core-dev/ubuntu-seeds/ubuntu.artful

[Jeremy Bicha]

Review: Needs Fixing

This was a more ambitious update than I expected! I marked a few things to fix and a few things to discuss if you still want to make the changes.

Diff comments:

> === modified file 'live'
> --- live	2016-03-18 18:22:03 +0000
> +++ live	2017-06-24 20:40:21 +0000
> @@ -28,18 +28,23 @@
>  ## hyphenation and thesaurus
>   * Languages: en-us de fr it ru
>   * hyphen-${Languages}
> + * hyphen-en-ca
> + * hyphen-en-gb
> + * hyphen-pt-br
> + * hyphen-pt-pt
>   * mythes-${Languages}
>   * mythes-en-au
>   * mythes-de-ch
> + * mythes-pt-pt
>  
>  ## hunspell dict
> - * Languages: en-ca en-us de-at de-ch de-de fr ru
> + * Languages: en-au en-ca en-gb en-us en-za es fr it ru
>   * hunspell-${Languages}
> -
> -## myspell dict
> -(for languages which don't provide a hunspell dictionary yet)
> - * Languages: en-au en-gb en-za es pt it
> - * myspell-${Languages}
> + * hunspell-de-at-frami
> + * hunspell-de-ch-frami
> + * hunspell-de-de-frami
> + * hunspell-pt-br
> + * hunspell-pt-pt
>  

These extra hunspell dictionaries will add several MBs to the ISO so let's discuss this more, maybe in #ubuntu-desktop

>  # Other Dictionaries
>   * Languages: american british spanish portuguese brazilian ngerman ogerman swiss french italian
> 
> === modified file 'supported'
> --- supported	2017-05-08 13:00:33 +0000
> +++ supported	2017-06-24 20:40:21 +0000
> @@ -12,8 +12,9 @@
>   * /^libreoffice-l10n-/
>   * /^thunderbird-locale-/
>   * /^firefox-locale-/
> + * /^gnome-user-docs-/
> + * /^gnome-getting-started-docs-/
>   * poppler-data
> - * ibus-sunpinyin
>  

ibus-sunpinyin is still in language-selector's pkg_depends

>  The following input aids are also installed on demand by
>  language-selector:
> @@ -87,20 +64,6 @@
>   * dict-moby-thesaurus
>   * dict-vera
>   * dictd
> - * mythes-ca
> - * mythes-cs
> - * mythes-de
> - * mythes-de-ch
> - * mythes-en-au
> - * mythes-en-us
> - * mythes-fr
> - * mythes-hu
> - * mythes-it
> - * mythes-ne
> - * mythes-pl
> - * mythes-ro
> - * mythes-ru
> - * mythes-sk

Why not add the mythes packages to pkg_depends instead?

>   * wamerican
>   * wbrazilian
>   * wbritish
> @@ -126,20 +89,26 @@
>  
>  Fonts installed on demand by language-selector:
>  
> - * fonts-alee
>   * fonts-arabeyes
>   * fonts-arphic-ukai
>   * fonts-arphic-uming
> + * fonts-beng
> + * fonts-deva
>   * fonts-farsiweb
> - * fonts-indic

Let's keep fonts-indic in main as a useful metapackage

> + * fonts-gujr
> + * fonts-guru
>   * fonts-kacst
>   * fonts-khmeros
> + * fonts-knda
>   * fonts-lao
> + * fonts-lklug-sinhala
>   * fonts-manchufont
> + * fonts-mlym
>   * fonts-nafees
>   * fonts-nanum
>   * fonts-nanum-coding
> - * fonts-nanum-extra
> + * fonts-noto-cjk
> + * fonts-orya
>   * fonts-sil-abyssinica
>   * fonts-sil-ezra
>   * fonts-sil-nuosusil
> @@ -147,21 +116,23 @@
>   * fonts-sil-scheherazade
>   * fonts-takao-gothic
>   * fonts-takao-mincho
> + * fonts-taml
> + * fonts-telu
> + * fonts-tibetan-machine
>   * fonts-thai-tlwg
> - * fonts-tibetan-machine
>   * fonts-ukij-uyghur
>   * fonts-unfonts-core
> - * fonts-wqy-zenhei
>  
>  Input methods installed on demand by language-selector:
>  
>   * gtk-im-libthai
> - * ibus-anthy

I'd like more justification than LP: #1547845 to drop ibus-anthy from main

>   * ibus-chewing
>   * ibus-hangul
>   * ibus-m17n
> + * ibus-mozc
>   * ibus-sunpinyin
>   * ibus-table-cangjie
> + * ibus-table-quick-classic
>   * ibus-table-wubi
>   * ibus-unikey
>  


-- 
https://code.launchpad.net/~gunnarhj/ubuntu-seeds/ubuntu.artful_lang-support/+merge/326261
Your team Ubuntu Core Development Team is requested to review the proposed merge of lp:~gunnarhj/ubuntu-seeds/ubuntu.artful_lang-support into lp:~ubuntu-core-dev/ubuntu-seeds/ubuntu.artful.