[Merge] lp:~ahayzen/ubuntu-settings-components/add-fake-pdf-mode-and-other-fixes into lp:~phablet-team/ubuntu-settings-components/printer-components

[Jonas G. Drange]

Review: Needs Fixing

looks good, minor comment!

Diff comments:

> 
> === modified file 'plugins/Ubuntu/Settings/Printers/models/printermodel.cpp'
> --- plugins/Ubuntu/Settings/Printers/models/printermodel.cpp	2017-01-19 13:56:37 +0000
> +++ plugins/Ubuntu/Settings/Printers/models/printermodel.cpp	2017-01-19 19:53:41 +0000
> @@ -379,6 +383,11 @@
>      Q_UNUSED(recent);
>  }
>  
> +void PrinterFilter::filterOnPdf(const bool pdf)
> +{
> +    m_pdfEnabled = pdf;

here, filterOnPdf should set m_pdfEnabled to true (implicit in the fact that you're calling this method), and then set m_pdf = pdf…

> +}
> +
>  bool PrinterFilter::filterAcceptsRow(int sourceRow,
>                                       const QModelIndex &sourceParent) const
>  {


-- 
https://code.launchpad.net/~ahayzen/ubuntu-settings-components/add-fake-pdf-mode-and-other-fixes/+merge/315169
Your team Ubuntu Phablet Team is subscribed to branch lp:~phablet-team/ubuntu-settings-components/printer-components.