[Merge] lp:~dandrader/qtubuntu/resizeToolTip into lp:qtubuntu

Daniel d'Andrada daniel.dandrada at canonical.com
Tue Jan 17 19:15:39 UTC 2017


On 05/01/2017 15:32, Gerry Boland wrote:
> Review: Needs Information
>
> You're removing the ability for Qt to reposition an existing surface. I believe I've seen some Qt apps doing that for tooltips, resize & reposition a single surface which it used for all tooltips.
>
> Thus I'm not happy with this, but the core point is correct (not setting the new geometry in the surface spec if surface also moved)

I'm not seeing the original code doing anything with the geometry 
received from Qt (including position) for the so-called movable types. 
How come the original code resizes and repositions "movable" types? Am I 
missing something?


-- 
https://code.launchpad.net/~dandrader/qtubuntu/resizeToolTip/+merge/313799
Your team Ubuntu Phablet Team is subscribed to branch lp:qtubuntu.



More information about the Ubuntu-reviews mailing list