[Merge] lp:~alfonsosanchezbeato/qtubuntu-sensors/reimplement-haptics-backend into lp:qtubuntu-sensors

[Alfonso Sanchez-Beato]

Alfonso Sanchez-Beato has proposed merging lp:~alfonsosanchezbeato/qtubuntu-sensors/reimplement-haptics-backend into lp:qtubuntu-sensors.

Commit message:
This change rewrites QtFeedbackHapticsEffect backend for ubuntu.

The original implementation is to call APIs in libubuntu-platform-api, which then issue D-Bus calls to usensord. However, it seems in some cases instantiating a D-Bus call in such Qt module may result in segmentation fault. This change rewrites QtFeedbackHapticsEffect backend with QtDBus directly and works around this issue.

This change also tries to conform to QtFeedbackHaptics features definitions. Duration/period is now correctly supported, although this doesn't mean much because usensord does not support variable vibration intensity. It also provides a chance to stop a periodical vibration. The enable/state properties are now correctly set and returned.

Requested reviews:
  Ubuntu Phablet Team (phablet-team)

For more details, see:
https://code.launchpad.net/~alfonsosanchezbeato/qtubuntu-sensors/reimplement-haptics-backend/+merge/314717

This change rewrites QtFeedbackHapticsEffect backend for ubuntu.

The original implementation is to call APIs in libubuntu-platform-api, which then issue D-Bus calls to usensord. However, it seems in some cases instantiating a D-Bus call in such Qt module may result in segmentation fault. This change rewrites QtFeedbackHapticsEffect backend with QtDBus directly and works around this issue.

This change also tries to conform to QtFeedbackHaptics features definitions. Duration/period is now correctly supported, although this doesn't mean much because usensord does not support variable vibration intensity. It also provides a chance to stop a periodical vibration. The enable/state properties are now correctly set and returned.
-- 
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~alfonsosanchezbeato/qtubuntu-sensors/reimplement-haptics-backend into lp:qtubuntu-sensors.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 7954 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20170113/0f08f881/attachment.diff>