[Merge] ~ovidiu-florin/ka:master into ka:master
Jose Manuel Santamaria Lema
panfaust at gmail.com
Mon Feb 27 01:02:10 UTC 2017
Hi,
I have tested the patch against applications in staging, and checked the resulting htm using various web browsers from *yakkety*. Just FYI
* It works:
- with firefox
- with chromium
* It doesn't work:
- with konqueror using the KHTML engine
- with konqueror using the QtWebkit engine
- with rekonq (uses QtWebkit)
Nitpicking: wrt to user friendliness, I was expecting that checking the "Error" checkbox would display only the packages in "Error" status, however it works the other way around: clicking the checkboxes hides packages from the list. I guess what is tricking me is the meaning of the word "filter". So as a humble suggestion ¿what about changing the thing to...
"Show only packages in these states: <checkboxes>"
so clicking on the textboxes would show only the packages in the selected states?
Keep in mind that we could also add a filter for package name:
"Package name contains: <textbox> <button to click and show only the package in question>"
so the select_what_you_want_to_see logic makes more sense to me than the select_what_you_want_to_hide logic. Note that this logic (and meaning of the word 'filter') is the current logic used for the LP's web interface, see:
https://launchpad.net/~kubuntu-ppa/+archive/ubuntu/staging-frameworks/+packages
The idea of showing only the interesting packages looks very good to me, so thank you for working on this :)
Cheers.
--
https://code.launchpad.net/~ovidiu-florin/ka/+git/ka/+merge/318326
Your team Kubuntu Packagers is requested to review the proposed merge of ~ovidiu-florin/ka:master into ka:master.
More information about the Ubuntu-reviews
mailing list