[Merge] lp:~gerboland/ubuntu-keyboard/remove-mir-papi-dependence into lp:ubuntu-keyboard

Gerry Boland gerry.boland at canonical.com
Thu Feb 23 23:30:51 UTC 2017


Gerry Boland has proposed merging lp:~gerboland/ubuntu-keyboard/remove-mir-papi-dependence into lp:ubuntu-keyboard with lp:~michael-sheldon/ubuntu-keyboard/fix-mir-deprecation as a prerequisite.

Commit message:
Remove all build-time mir dependence

>From 0.64, the ubuntumirclient QPA offers all the features required:
- explicitly allow us to request input method surface (using a shared magic number, unfortunately Qt doesn't have any way to request an InputMethod-type window)
- use QWindow::setMask to designate the input region

Then can remove MirInputRegionUpdater entirely as a result, and no need to depend on qtbase5-private and its friends.

Also made minor fix for scenegraph warning being printed at startup.

Requested reviews:
  Ubuntu Phablet Team (phablet-team)

For more details, see:
https://code.launchpad.net/~gerboland/ubuntu-keyboard/remove-mir-papi-dependence/+merge/318167

To test, you need 
https://code.launchpad.net/~gerboland/qtubuntu/better-input-method-support/+merge/318163
-- 
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~gerboland/ubuntu-keyboard/remove-mir-papi-dependence into lp:ubuntu-keyboard.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 11007 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20170223/430950c3/attachment-0001.diff>


More information about the Ubuntu-reviews mailing list