[Merge] lp:~fboucault/webbrowser-app/fix_fullscreen into lp:webbrowser-app/staging
Florian Boucault
florian.boucault at canonical.com
Thu Feb 23 11:01:46 UTC 2017
Florian Boucault has proposed merging lp:~fboucault/webbrowser-app/fix_fullscreen into lp:webbrowser-app/staging.
Commit message:
Fullscreen improvements:
* Simplify fullscreen: single entry point BrowserWindow.setFullscreen()
* Do not go fullscreen if already fullscreen. Fixes case where fullscreen could not be exited anymore.
* Make chrome hide when webview is fullscreen. Remove unused property Browser.fullscreen.
Requested reviews:
Ubuntu Phablet Team (phablet-team)
Related bugs:
Bug #1665727 in webbrowser-app (Ubuntu): "Window stuck in fullscreen mode"
https://bugs.launchpad.net/ubuntu/+source/webbrowser-app/+bug/1665727
For more details, see:
https://code.launchpad.net/~fboucault/webbrowser-app/fix_fullscreen/+merge/318091
Fullscreen improvements:
* Simplify fullscreen: single entry point BrowserWindow.setFullscreen()
* Do not go fullscreen if already fullscreen. Fixes case where fullscreen could not be exited anymore.
* Make chrome hide when webview is fullscreen. Remove unused property Browser.fullscreen.
--
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~fboucault/webbrowser-app/fix_fullscreen into lp:webbrowser-app/staging.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 2851 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20170223/44c30079/attachment-0001.diff>
More information about the Ubuntu-reviews
mailing list