[Merge] lp:~phablet-team/dialer-app/voip_support into lp:dialer-app

[Renato Araujo Oliveira Filho]

Review: Needs Information

Some small comments.

Diff comments:

> === modified file 'src/qml/DialerPage/DialerPage.qml'
> --- src/qml/DialerPage/DialerPage.qml	2016-10-18 09:28:54 +0000
> +++ src/qml/DialerPage/DialerPage.qml	2017-02-03 18:26:51 +0000
> @@ -56,10 +56,17 @@
>  
>          ]
>          title: page.title
> +        focus: false
>          trailingActionBar {
>              actions: mainView.greeterMode ? actionsGreeter : actionsNormal
>          }
>  
> +        onFocusChanged: {
> +            if (focus) {
> +                focus = false
> +            }
> +        }
> +

Why do you need this? Does the focus property changes automatically? Could you add a comment about that?

>          leadingActionBar {
>              property list<QtObject> backActionList: [
>                  Action {
> @@ -165,6 +176,15 @@
>          }
>      ]
>  
> +    // Forward key presses
> +    Keys.onPressed: {
> +        if (!active) {
> +            return
> +        }
> +
> +        keypad.keyPressed(event.key, event.text)
> +    }
> +

Did you tried? http://doc.qt.io/qt-5/qml-qtquick-keys.html#forwardTo-prop

>      function triggerCallAnimation() {
>          callAnimation.start();
>      }


-- 
https://code.launchpad.net/~phablet-team/dialer-app/voip_support/+merge/313385
Your team Ubuntu Phablet Team is subscribed to branch lp:dialer-app.