[Merge] lp:~ahayzen/qtubuntu-print/add-unit-tests into lp:qtubuntu-print

Andrew Hayzen andrew.hayzen at canonical.com
Mon Feb 20 16:40:49 UTC 2017


Andrew Hayzen has proposed merging lp:~ahayzen/qtubuntu-print/add-unit-tests into lp:qtubuntu-print with lp:~ahayzen/qtubuntu-print/empty-branch-for-bileto as a prerequisite.

Commit message:
* Move src files into their own directory
* Modify po to read src correctly
* Add unit tests for qtubuntu-print checking the printerName exists and the name, makeandmodel and location are correct
* Add fakeprint plugin to unittests which checks we are actually loading a custom plugin and not the system one

Requested reviews:
  Ubuntu Phablet Team (phablet-team)

For more details, see:
https://code.launchpad.net/~ahayzen/qtubuntu-print/add-unit-tests/+merge/317785

* Move src files into their own directory
* Modify po to read src correctly
* Add unit tests for qtubuntu-print checking the printerName exists and the name, makeandmodel and location are correct
* Add fakeprint plugin to unittests which checks we are actually loading a custom plugin and not the system one
-- 
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~ahayzen/qtubuntu-print/add-unit-tests into lp:qtubuntu-print.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 17324 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20170220/f02c8082/attachment-0001.diff>


More information about the Ubuntu-reviews mailing list