[Merge] lp:~jonas-drange/ubuntu-settings-components/buffer-printer-state-events into lp:~phablet-team/ubuntu-settings-components/printer-components

Andrew Hayzen andrew.hayzen at canonical.com
Fri Feb 17 14:57:11 UTC 2017


Review: Approve

As discussed the signals will get queued [0], so this won't be racy :-)

LGTM \o/

0 - https://wiki.qt.io/Threads_Events_QObjects#Signals_and_slots_across_threads
(...an automatic connection (the default) means that if the thread the receiver is living in is the same as the current thread, a direct connection is used; otherwise, a queued connection is used...)
-- 
https://code.launchpad.net/~jonas-drange/ubuntu-settings-components/buffer-printer-state-events/+merge/317485
Your team Ubuntu Phablet Team is subscribed to branch lp:~phablet-team/ubuntu-settings-components/printer-components.



More information about the Ubuntu-reviews mailing list