[Merge] lp:~jonas-drange/ubuntu-settings-components/asyncness into lp:~phablet-team/ubuntu-settings-components/printer-components

Andrew Hayzen andrew.hayzen at canonical.com
Wed Feb 15 18:43:35 UTC 2017


Review: Needs Fixing

As the diff is so long and LP is truncating, but I still wanted to put my comments inline. I've generated a diff with my first round comments here http://pastebin.ubuntu.com/24002329/

Also removing a 'generic' printer still freezes the example app for me, this is what i see in the cups logs http://pastebin.ubuntu.com/24002348/
-- 
https://code.launchpad.net/~jonas-drange/ubuntu-settings-components/asyncness/+merge/316786
Your team Ubuntu Phablet Team is subscribed to branch lp:~phablet-team/ubuntu-settings-components/printer-components.



More information about the Ubuntu-reviews mailing list