[Merge] lp:~ahayzen/webbrowser-app/migrate-to-tabs-component into lp:webbrowser-app/staging

Andrew Hayzen andrew.hayzen at canonical.com
Wed Feb 15 17:15:55 UTC 2017


1) When closing a tab, I’m seeing the following warning:

TabsBar.qml:57: TypeError: Cannot read property 'localIcon' of undefined


FIXED

2) QQmlContext errors when there are enough tabs open to cause some to be hidden

I've fixed this in the ubuntu-ui-extras, what was happening was at application startup, the loader is set to start loading a component but while it is doing this in async the tab is destroyed (as it is out of view in the listview) and then when the component is complete there is no context for it to go to. So now when the tab is destroyed it unsets the loader source to prevent it from performing the load. Please test with the following branch: https://code.launchpad.net/~ahayzen/ubuntu-ui-extras/fix-context-errors-for-unloaded-tabs/+merge/317364
-- 
https://code.launchpad.net/~ahayzen/webbrowser-app/migrate-to-tabs-component/+merge/312340
Your team Ubuntu Phablet Team is subscribed to branch lp:webbrowser-app/staging.



More information about the Ubuntu-reviews mailing list