[Merge] lp:~mterry/webbrowser-app/snap-appid into lp:webbrowser-app

Michael Terry michael.terry at canonical.com
Thu Feb 9 22:21:39 UTC 2017


Michael Terry has proposed merging lp:~mterry/webbrowser-app/snap-appid into lp:webbrowser-app.

Commit message:
Properly set the APP_ID variable for the snappy world.

Requested reviews:
  Ubuntu Phablet Team (phablet-team)

For more details, see:
https://code.launchpad.net/~mterry/webbrowser-app/snap-appid/+merge/316909

Properly set the APP_ID variable for the snappy world.

In snappy, it's SNAPNAME_COMMAND_REVISION.

This doesn't matter a lot, I don't think.  But one thing it was breaking was opening URLs from url-dispatcher.  The APP_ID is used to expose a path on DBus for url-dispatcher to call, and it won't be found unless the above scheme is used.
-- 
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~mterry/webbrowser-app/snap-appid into lp:webbrowser-app.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 415 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20170209/cbe56aa2/attachment.diff>


More information about the Ubuntu-reviews mailing list