[Merge] lp:~artmello/qtubuntu/qtubuntu-new_mir_api into lp:qtubuntu

Daniel d'Andrada daniel.dandrada at canonical.com
Tue Feb 7 18:22:32 UTC 2017


In several headers you're replacing a forward declaration with a #include.

"""
- struct MirSurface;
"""

"""
+ #include <mir_toolkit/mir_window.h>
"""

Please maintain the forward declaration style. It makes the header files more lightweight.
-- 
https://code.launchpad.net/~artmello/qtubuntu/qtubuntu-new_mir_api/+merge/316577
Your team Ubuntu Phablet Team is subscribed to branch lp:qtubuntu.



More information about the Ubuntu-reviews mailing list