[Merge] lp:~ahayzen/ubuntu-settings-components/extract-job-attributes into lp:~phablet-team/ubuntu-settings-components/printer-components

[Jonas G. Drange]

Review: Approve

Looks good, thanks! One small comment.

Diff comments:

> 
> === modified file 'plugins/Ubuntu/Settings/Printers/printer/printerjob.h'
> --- plugins/Ubuntu/Settings/Printers/printer/printerjob.h	2017-02-03 14:43:41 +0000
> +++ plugins/Ubuntu/Settings/Printers/printer/printerjob.h	2017-02-07 13:43:04 +0000
> @@ -37,18 +38,24 @@
>      Q_PROPERTY(bool collate READ collate WRITE setCollate NOTIFY collateChanged)
>      Q_PROPERTY(int colorModel READ colorModel WRITE setColorModel NOTIFY colorModelChanged)
>      Q_PROPERTY(PrinterEnum::ColorModelType colorModelType READ colorModelType NOTIFY colorModelTypeChanged)
> +    Q_PROPERTY(QDateTime completedTime NOTIFY completedTimeChanged)

…/printerjob.h:41: Warning: Property declaration completedTime has no READ accessor function or associated MEMBER variable. The property will be invalid.

>      Q_PROPERTY(int copies READ copies WRITE setCopies NOTIFY copiesChanged)
> +    Q_PROPERTY(QDateTime creationTime READ creationTime NOTIFY creationTimeChanged)
>      Q_PROPERTY(int duplexMode READ duplexMode WRITE setDuplexMode NOTIFY duplexModeChanged)
>      Q_PROPERTY(bool isTwoSided READ isTwoSided NOTIFY isTwoSidedChanged)
>      Q_PROPERTY(bool landscape READ landscape WRITE setLandscape NOTIFY landscapeChanged)
> +    Q_PROPERTY(QStringList messages READ messages NOTIFY messagesChanged)
>  //    Q_PROPERTY(Printer *printer READ printer WRITE setPrinter NOTIFY printerChanged)
>      Q_PROPERTY(QString printerName READ printerName WRITE setPrinterName NOTIFY printerNameChanged)
>      Q_PROPERTY(QString printRange READ printRange WRITE setPrintRange NOTIFY printRangeChanged)
>      Q_PROPERTY(PrinterEnum::PrintRange printRangeMode READ printRangeMode WRITE setPrintRangeMode NOTIFY printRangeModeChanged)
> +    Q_PROPERTY(QDateTime processingTime READ processingTime NOTIFY processingTimeChanged)
>      Q_PROPERTY(int quality READ quality WRITE setQuality NOTIFY qualityChanged)
>      Q_PROPERTY(bool reverse READ reverse WRITE setReverse NOTIFY reverseChanged)
> +    Q_PROPERTY(int size READ size NOTIFY sizeChanged)
>      Q_PROPERTY(PrinterEnum::JobState state READ state NOTIFY stateChanged)
>      Q_PROPERTY(QString title READ title WRITE setTitle NOTIFY titleChanged)
> +    Q_PROPERTY(QString user READ user NOTIFY userChanged)
>  
>      friend class PrinterCupsBackend;
>  public:


-- 
https://code.launchpad.net/~ahayzen/ubuntu-settings-components/extract-job-attributes/+merge/316563
Your team Ubuntu Phablet Team is subscribed to branch lp:~phablet-team/ubuntu-settings-components/printer-components.