[Merge] lp:~ahayzen/ubuntu-settings-components/fix-compiler-warnings into lp:~phablet-team/ubuntu-settings-components/printer-components

Andrew Hayzen andrew.hayzen at canonical.com
Mon Feb 6 14:01:34 UTC 2017


Andrew Hayzen has proposed merging lp:~ahayzen/ubuntu-settings-components/fix-compiler-warnings into lp:~phablet-team/ubuntu-settings-components/printer-components.

Commit message:
* Resolve console warnings - add TODOs in methods that should be implemented where I've put a fake return value for now
* Set a default for switches that compiler thinks it can reach the end of the control without
* Add return values for methods that are not implemented yet
* Add Q_UNUSED for parameters that aren't used

Requested reviews:
  Ubuntu Phablet Team (phablet-team)

For more details, see:
https://code.launchpad.net/~ahayzen/ubuntu-settings-components/fix-compiler-warnings/+merge/316457

* Resolve console warnings - add TODOs in methods that should be implemented where I've put a fake return value for now
* Set a default for switches that compiler thinks it can reach the end of the control without
* Add return values for methods that are not implemented yet
* Add Q_UNUSED for parameters that aren't used
-- 
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~ahayzen/ubuntu-settings-components/fix-compiler-warnings into lp:~phablet-team/ubuntu-settings-components/printer-components.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 17052 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20170206/42aa40b4/attachment.diff>


More information about the Ubuntu-reviews mailing list