[Merge] lp:~ahayzen/webbrowser-app/migrate-to-tabs-component into lp:webbrowser-app/staging
Olivier Tilloy
olivier.tilloy at canonical.com
Thu Feb 2 16:54:12 UTC 2017
Review: Needs Fixing
qtdeclarative5-ubuntu-ui-extras0.2 needs to be added as a runtime dependency of webbrowser-app in debian/control.
When building the snap locally, the resulting snap file is 20MB, up from 2MB previously. And sure enough it ships lots of Qt libraries in usr/lib/$ARCH/. What’s the reason for building ui-extras from source instead of adding it the stage packages? Or even taking it one step further, shouldn’t we add qtdeclarative5-ubuntu-ui-extras0.2 to the stage packages in the ubuntu-app-platform snap?
--
https://code.launchpad.net/~ahayzen/webbrowser-app/migrate-to-tabs-component/+merge/312340
Your team Ubuntu Phablet Team is subscribed to branch lp:webbrowser-app/staging.
More information about the Ubuntu-reviews
mailing list